goal-pr

Goal PR

target_pr = the user's request

This skill drives a pull request all the way to merge. It repeatedly runs the review-pr skill, fixes every finding of severity mid or above, and merges the PR once a review round reports no mid-or-above findings.

0. Determine and Prepare the Target PR

1. If target_pr is provided (e.g. 123, #123, or a PR URL), use it.

2. Otherwise, look for the PR of the current branch:

   gh pr view --json number,title,state,headRefName 2>/dev/null
   

3. If no PR exists yet, create one (this satisfies the "PR is the goal" intent):

   • Use the commit-push-pr skill to commit the current changes, push the branch, and open a PR.
   • Then resolve target_pr to the freshly created PR number.

Confirm that the current local branch is the PR's head branch, because the fix phase below must commit and push fixes onto that branch. If they differ, ask the user how to proceed and stop.

1. Exit Condition

The loop exits when a single review round satisfies both of:

• 0 findings of severity mid, high, or critical (only low findings, or none at all, may remain).
• The PR's GitHub Actions checks are green — no check is fail or pending.

Set a hard safety cap of 10 iterations. If the exit condition is still not met at the cap, stop the loop and report the remaining findings (and any failing CI) to the user for a manual decision instead of merging.

2. Iteration Loop

Repeat the following until the exit condition is satisfied or the cap is hit.

2-1. Review Phase

Use the review-pr skill with target_pr. It assigns each finding a severity (low / mid / high / critical) and a sequential number, and also reports the GitHub Actions workflow status.

Note: the review-pr skill only reads remote state and must not switch the local branch. Keep that constraint intact during the review phase.

2-2. Evaluate the Exit Condition

Use both the findings and the GitHub Actions status from the review result.

• If mid + high + critical == 0 and CI is green (no fail / pending check): exit the loop and go to Section 3.
• If there are mid-or-above findings, or any CI check is failing: proceed to the fix phase to address them.
• If the findings are clean but CI is still pending: wait for the checks to finish (re-check with gh pr checks <pr>), then re-evaluate. Do not proceed to merge while checks are pending.

2-3. Fix Phase

Fix every finding of severity mid or above on the current branch (you may also fix low findings opportunistically). Unlike the review phase, this phase works on the local branch directly:

1. Edit the relevant files to address each mid-or-above finding. If you intentionally reject a finding, record the reason and treat it as resolved.

2. Run pnpm cicheck (or the narrower pnpm cicheck:code / cicheck:content when appropriate) and fix any failures before continuing.

3. Stage only the files you changed for the fix (review git status first so unrelated or generated files are not swept in), commit with a descriptive message, and push to the PR's head branch:

   git status
   git add <changed files>
   git commit -m "<message>"
   git push origin HEAD
   

Emit a short status line such as Iteration N — mid: X, high: Y, critical: Z; pushed fixes, then return to Section 2-1 so the updated PR (and its CI) is reviewed again.

3. Merge

Only reach this step once the exit condition in Section 1 holds — clean findings and green CI. Merge the PR by using the merge-pr skill with target_pr. That skill verifies the PR is open, checks GitHub Actions status, merges with gh pr merge --admin --merge, posts a thank-you comment, and cleans up the local branch.

Safety rules for the merge:

• Never merge while any check is fail or pending. gh pr merge --admin bypasses required checks, so it must not be used to force past red or in-progress CI. If CI is failing, return to the fix phase; if it is pending, wait.
• If the PR touches GitHub Actions workflows, build/release configuration, or dependency manifests (e.g. package.json, lockfiles), do not auto-merge. Stop and ask the user to confirm, since these changes carry higher risk.

4. Final Report

After the loop ends, report to the user:

• Outcome: Merged (exit condition met and PR merged) or Capped (hit the iteration cap without converging; not merged).
• Iterations: how many review/fix rounds were executed.
• Final severity summary: the counts per severity from the last review round.
• Result: the merged PR number and title, or — when capped — the list of remaining mid-or-above findings for the user to decide on.